fredia commented on code in PR #25884:
URL: https://github.com/apache/flink/pull/25884#discussion_r1909979879
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/ForStFlinkFileSystem.java:
##########
@@ -119,7 +121,11 @@ public static FileBasedCache getFileBasedCache(
new File(cacheBase.toString()), cacheReservedSize,
SST_FILE_SIZE);
}
return new FileBasedCache(
- Integer.MAX_VALUE, cacheLimitPolicy,
cacheBase.getFileSystem(), cacheBase);
+ Integer.MAX_VALUE,
+ cacheLimitPolicy,
+ cacheBase.getFileSystem(),
Review Comment:
`cacheBase.getFileSystem()` can throw IOException.
If we get fileSystem in `FileBasedCache` constructor, the constructor would
throw IOException, this is something I don't want to introduce.
So, I prefer to keep ` cacheBase.getFileSystem()` in parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
