sn-12-3 commented on code in PR #25528:
URL: https://github.com/apache/flink/pull/25528#discussion_r1915076347
##########
flink-python/pyflink/datastream/tests/test_stream_execution_environment.py:
##########
@@ -260,57 +260,6 @@ def test_execute_async(self):
execution_result = job_client.get_job_execution_result().result()
self.assertEqual(str(job_id), str(execution_result.get_job_id()))
- def test_add_python_file(self):
Review Comment:
Going through the test, I think it is verifying `FromDataStream` and
`ToAppendStream` functionalities
[here](https://github.com/apache/flink/pull/25528/files#diff-01e52e6f08b44b6f0b872f1341b12f7e3ecd2da3fe789953332b26bb1f9ea3f1L302-L307),
where both methods are going to be removed as part of
https://issues.apache.org/jira/browse/FLINK-36485 and
https://issues.apache.org/jira/browse/FLINK-36488, so I have removed this test.
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/WindowAggregateITCase.scala:
##########
@@ -1290,47 +1290,6 @@ class WindowAggregateITCase(
.isEqualTo(expected.sorted.mkString("\n"))
}
- @TestTemplate
- def testDistinctAggWithMergeOnEventTimeSessionWindow(): Unit = {
Review Comment:
After removing the `toAppendStream` method, this test case started failing
in CI pipeline. Going through the test, this also seem to check same
functionality
[here](https://github.com/apache/flink/pull/25528/files#diff-eeaadb21398da5ae5cda3c2c25f94173cf11fd25c1bcc94d4a90b930c91cd465L1321).
Is removing test case ok, or does it required to be looked further ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
