xuyangzhong commented on code in PR #25528:
URL: https://github.com/apache/flink/pull/25528#discussion_r1914694982
##########
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/api/bridge/java/StreamTableEnvironment.java:
##########
@@ -788,61 +788,6 @@ DataStream<Row> toChangelogStream(
* be used as source of truth.
*/
@Deprecated
- <T> DataStream<T> toAppendStream(Table table, Class<T> clazz);
-
- /**
- * Converts the given {@link Table} into an append {@link DataStream} of a
specified type.
- *
- * <p>The {@link Table} must only have insert (append) changes. If the
{@link Table} is also
- * modified by update or delete changes, the conversion will fail.
- *
- * <p>The fields of the {@link Table} are mapped to {@link DataStream}
fields as follows:
- *
- * <ul>
- * <li>{@link Row} and {@link org.apache.flink.api.java.tuple.Tuple}
types: Fields are mapped
- * by position, field types must match.
- * <li>POJO {@link DataStream} types: Fields are mapped by field name,
field types must match.
- * </ul>
- *
- * @param table The {@link Table} to convert.
- * @param typeInfo The {@link TypeInformation} that specifies the type of
the {@link
- * DataStream}.
- * @param <T> The type of the resulting {@link DataStream}.
- * @return The converted {@link DataStream}.
- * @deprecated Use {@link #toDataStream(Table, Class)} instead. It
integrates with the new type
- * system and supports all kinds of {@link DataTypes} that the table
runtime can produce.
- * The semantics might be slightly different for raw and structured
types. Use {@code
- * toDataStream(DataTypes.of(TypeInformation.of(Class)))} if {@link
TypeInformation} should
- * be used as source of truth.
- */
- @Deprecated
- <T> DataStream<T> toAppendStream(Table table, TypeInformation<T> typeInfo);
-
- /**
- * Converts the given {@link Table} into a {@link DataStream} of add and
retract messages. The
Review Comment:
You removed the comment for toRetractStream but kept the comment for
toAppendStream.
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/WindowAggregateITCase.scala:
##########
@@ -1290,47 +1290,6 @@ class WindowAggregateITCase(
.isEqualTo(expected.sorted.mkString("\n"))
}
- @TestTemplate
- def testDistinctAggWithMergeOnEventTimeSessionWindow(): Unit = {
Review Comment:
ditto
##########
flink-python/pyflink/datastream/tests/test_stream_execution_environment.py:
##########
@@ -260,57 +260,6 @@ def test_execute_async(self):
execution_result = job_client.get_job_execution_result().result()
self.assertEqual(str(job_id), str(execution_result.get_job_id()))
- def test_add_python_file(self):
Review Comment:
I don't think we can directly remove this test, as it seems to verify other
functionalities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
