davidradl commented on code in PR #25528:
URL: https://github.com/apache/flink/pull/25528#discussion_r1916692362
##########
flink-python/pyflink/table/table_environment.py:
##########
@@ -1784,6 +1784,29 @@ def to_data_stream(self, table: Table) -> DataStream:
"""
return DataStream(self._j_tenv.toDataStream(table._j_table))
+ def to_data_stream(self, table: Table, type_info: TypeInformation) ->
DataStream:
+ """
+ Converts the given Table into a DataStream.
+
+ Since the DataStream API does not support changelog processing
natively, this method
+ assumes append-only/insert-only semantics during the table-to-stream
conversion. The records
Review Comment:
nit: the documentation only refers to insert-only. Can we remove append-only
or is this indicating another semantic?
Maybe involve parts of the original comment "Converts the given Table into a
DataStream of a specified type. Since the DataStream API does not support
changelog processing natively, the table must only have insert (append)
changes. If the Table is also modified by update or delete changes, the
conversion will fail."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
