fredia commented on code in PR #26063:
URL: https://github.com/apache/flink/pull/26063#discussion_r1926644967
##########
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/AbstractAsyncStateStreamOperatorV2.java:
##########
@@ -163,17 +163,43 @@ public final <T> void setAsyncKeyedContextElement(
// in Fig.5, each state request itself is also protected by a paired
reference count.
currentProcessingContext.retain();
asyncExecutionController.setCurrentContext(currentProcessingContext);
+ newKeySelected(currentProcessingContext.getKey());
+ }
+
+ /**
+ * A hook that will be invoked after a new key is selected. It is not
recommended to perform
+ * async state here. Only some synchronous logic is suggested.
+ *
+ * @param newKey the new key selected.
+ */
+ public void newKeySelected(Object newKey) {
+ // By default, do nothing.
+ // Subclass could override this method to do some operations when a
new key is selected.
+ }
+
+ @Override
+ protected <T> void internalSetKeyContextElement(
+ StreamRecord<T> record, KeySelector<T, ?> selector) throws
Exception {
+ // This method is invoked only when isAsyncStateProcessingEnabled() is
false.
Review Comment:
nit: Add check here too
##########
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/AbstractAsyncStateStreamOperator.java:
##########
@@ -300,32 +312,36 @@ public <K, N> InternalTimerService<N>
getInternalTimerService(
}
@Override
- @SuppressWarnings("unchecked")
public void setKeyContextElement1(StreamRecord record) throws Exception {
+ // This method is invoked only when isAsyncStateProcessingEnabled() is
false.
Review Comment:
nit: Add a check here?
Check `isAsyncStateProcessingEnabled = false`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
