Zakelly commented on code in PR #26063:
URL: https://github.com/apache/flink/pull/26063#discussion_r1926690735
##########
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/AbstractAsyncStateStreamOperator.java:
##########
@@ -300,32 +312,36 @@ public <K, N> InternalTimerService<N>
getInternalTimerService(
}
@Override
- @SuppressWarnings("unchecked")
public void setKeyContextElement1(StreamRecord record) throws Exception {
+ // This method is invoked only when isAsyncStateProcessingEnabled() is
false.
Review Comment:
I'd suggest not. We are on the hot path of record processing here, it would
be nice if we can prevent some overhead here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
