davidradl commented on code in PR #26245:
URL: https://github.com/apache/flink/pull/26245#discussion_r1982992358
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStMapState.java:
##########
@@ -139,7 +140,8 @@ public byte[] serializeValue(UV value) throws IOException {
public UV deserializeValue(byte[] valueBytes) throws IOException {
DataInputDeserializer inputView = valueDeserializerView.get();
inputView.setBuffer(valueBytes);
- return userValueSerializer.deserialize(inputView);
+ boolean isNull = inputView.readBoolean();
Review Comment:
nit: could be one line and not introduce a variable
At the moment it reads a boolean - if it is true then we return null, if
false we deserialize. It would be more intuitive, if the flag was true when
there was a value to serialise otherwise false. I guess this is the way this
has been designed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
