davidradl commented on code in PR #26245:
URL: https://github.com/apache/flink/pull/26245#discussion_r1982983459
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStDBMapEntryIterRequest.java:
##########
@@ -59,10 +59,12 @@ public Collection<Map.Entry<UK, UV>> deserializeElement(
List<RawEntry> entries, int userKeyOffset) throws IOException {
Collection<Map.Entry<UK, UV>> deserializedEntries = new
ArrayList<>(entries.size());
for (RawEntry en : entries) {
- deserializedEntries.add(
- new MapEntry<>(
- deserializeUserKey(en.rawKeyBytes, userKeyOffset),
- deserializeUserValue(en.rawValueBytes)));
+ // Since be written in Sync mode, the user value can be null.
Review Comment:
nit: `be` does not make sense in the comment. Could you detail a little
more why this can be zero please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
