aiwenmo commented on code in PR #3812:
URL: https://github.com/apache/flink-cdc/pull/3812#discussion_r1992559031


##########
flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/MySqlToDorisE2eITCase.java:
##########
@@ -336,6 +336,92 @@ public void testSyncWholeDatabase() throws Exception {
         }
     }
 
+    @Test
+    public void testSyncWholeDatabaseInBatchMode() throws Exception {
+        String databaseName = mysqlInventoryDatabase.getDatabaseName();
+        String pipelineJob =
+                String.format(
+                        "source:\n"
+                                + "  type: mysql\n"
+                                + "  hostname: mysql\n"
+                                + "  port: 3306\n"
+                                + "  username: %s\n"
+                                + "  password: %s\n"
+                                + "  tables: %s.\\.*\n"
+                                + "  server-id: 5400-5404\n"
+                                + "  server-time-zone: UTC\n"

Review Comment:
   It is currently needed. Since batch mode is only applicable to snapshots, 
should it be optimized so that snapshot is the default option if not specified?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to