lvyanquan commented on code in PR #3812:
URL: https://github.com/apache/flink-cdc/pull/3812#discussion_r2000903783
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlSource.java:
##########
@@ -200,7 +201,22 @@ public SplitEnumerator<MySqlSplit, PendingSplitsState>
createEnumerator(
validator.validate();
final MySqlSplitAssigner splitAssigner;
- if (!sourceConfig.getStartupOptions().isStreamOnly()) {
+ // In batch mode, only split snapshots.
Review Comment:
This change will also modify the behavior of Stream mode, should we update
the comment to `In snapshot-only startup option`?
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlSource.java:
##########
@@ -200,7 +201,22 @@ public SplitEnumerator<MySqlSplit, PendingSplitsState>
createEnumerator(
validator.validate();
final MySqlSplitAssigner splitAssigner;
- if (!sourceConfig.getStartupOptions().isStreamOnly()) {
+ // In batch mode, only split snapshots.
Review Comment:
This change will also modify the behavior of Stream mode, should we update
the comment to `In snapshot-moly mode`?
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlSource.java:
##########
@@ -200,7 +201,22 @@ public SplitEnumerator<MySqlSplit, PendingSplitsState>
createEnumerator(
validator.validate();
final MySqlSplitAssigner splitAssigner;
- if (!sourceConfig.getStartupOptions().isStreamOnly()) {
+ // In batch mode, only split snapshots.
Review Comment:
This change will also modify the behavior of Stream mode, should we update
the comment to `In snapshot-moly mode`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
