aiwenmo commented on code in PR #3812:
URL: https://github.com/apache/flink-cdc/pull/3812#discussion_r2003444291
##########
flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/translator/DataSinkTranslator.java:
##########
@@ -158,8 +176,7 @@ private <CommT> void addCommittingTopology(
((WithPreCommitTopology<Event, CommT>)
sink).addPreCommitTopology(written);
}
- // TODO: Hard coding stream mode and checkpoint
- boolean isBatchMode = false;
+ // TODO: Hard coding checkpoint
boolean isCheckpointingEnabled = true;
Review Comment:
Some sinks need to rely on checkpointing to complete the writing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
