twalthr commented on code in PR #26306:
URL: https://github.com/apache/flink/pull/26306#discussion_r2005307532
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/ChangelogMode.java:
##########
@@ -71,7 +82,21 @@ public static ChangelogMode insertOnly() {
* contain {@link RowKind#UPDATE_BEFORE} rows.
*/
public static ChangelogMode upsert() {
- return UPSERT;
+ return upsert(false);
+ }
+
+ /**
+ * Shortcut for an upsert changelog that describes idempotent updates on a
key and thus does not
+ * contain {@link RowKind#UPDATE_BEFORE} rows.
+ *
+ * <p>Tells the system the DELETEs contain the full record and not just
the key.
+ */
+ public static ChangelogMode upsert(boolean withFullDeletes) {
+ if (withFullDeletes) {
Review Comment:
Should we invert this? Otherwise this method and the builder are inverse and
might cause unintended bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
