davidradl commented on code in PR #26306:
URL: https://github.com/apache/flink/pull/26306#discussion_r2005915641
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/ChangelogMode.java:
##########
@@ -43,6 +43,15 @@ public final class ChangelogMode {
.addContainedKind(RowKind.INSERT)
.addContainedKind(RowKind.UPDATE_AFTER)
.addContainedKind(RowKind.DELETE)
+ .deletesOnKey(true)
Review Comment:
I am curious what you think. The config here has .deletesOnKey. But all the
way through the code we are using withFullDeletes as the boolean. So
deletesOnKey= true in the config is tracked as withFullDeletes = false and vice
versa.
I wonder if it is worth changing the config so it is deletesOnRecord. Then
true in the config maps to withFullDeletes and both would be the same boolean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
