davidradl commented on code in PR #26306:
URL: https://github.com/apache/flink/pull/26306#discussion_r2005900173
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java:
##########
@@ -457,6 +457,22 @@ private static RowKind parseRowKind(String
rowKindShortString) {
.withDescription(
"Option to determine whether or not to require the
distribution bucket count");
+ private static final ConfigOption<Boolean> SINK_SUPPORTS_DELETE_ON_KEY =
+ ConfigOptions.key("sink.supports-delete-on-key")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "Option to determine whether or not to require
deletes to have the"
Review Comment:
nit: I wonder if we can simplify the words WDYT?
`Option to determine whether or not to require deletes to have the entire
row or is a delete by key sufficient.`
->
`Indicates to deletes will be done by key; otherwise deletes will be done by
record.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
