gguptp commented on code in PR #193:
URL:
https://github.com/apache/flink-connector-aws/pull/193#discussion_r2011547100
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/split/DynamoDbStreamsShardSplit.java:
##########
@@ -40,6 +43,7 @@ public final class DynamoDbStreamsShardSplit implements
SourceSplit {
private final String shardId;
private final StartingPosition startingPosition;
private final String parentShardId;
+ private final NavigableMap<Long, Set<String>> finishedSplitsMap;
Review Comment:
agree, i can just use a Set<String> here
##########
flink-connector-aws/flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/source/reader/DynamoDbStreamsSourceReaderTest.java:
##########
@@ -158,4 +165,148 @@ void testAddSplitsRegistersAndUpdatesShardMetricGroup()
throws Exception {
TestUtil.assertMillisBehindLatest(
split, TestUtil.MILLIS_BEHIND_LATEST_TEST_VALUE,
metricListener);
}
+
+ @Test
+ void testSnapshotStateWithFinishedSplits() throws Exception {
+ // Create and add a split
+ DynamoDbStreamsShardSplit split = getTestSplit();
+ List<DynamoDbStreamsShardSplit> splits =
Collections.singletonList(split);
+ sourceReader.addSplits(splits);
+
+ // Set checkpoint ID by taking initial snapshot
+ List<DynamoDbStreamsShardSplit> initialSnapshot =
sourceReader.snapshotState(1L);
+ assertThat(initialSnapshot).hasSize(1).containsExactly(split);
+
+ // Simulate split finishing
+ Map<String, DynamoDbStreamsShardSplitState> finishedSplits = new
HashMap<>();
+ finishedSplits.put(split.splitId(), new
DynamoDbStreamsShardSplitState(split));
+ sourceReader.onSplitFinished(finishedSplits);
+
+ // Take another snapshot
+ List<DynamoDbStreamsShardSplit> snapshotSplits =
sourceReader.snapshotState(1L);
+
+ // Verify we have 2 splits - the original split and the state split
+ assertThat(snapshotSplits).hasSize(2);
+
+ // Find and verify the state split
+ Optional<DynamoDbStreamsShardSplit> stateSplitOptional =
+ snapshotSplits.stream()
+ .filter(s ->
s.getShardId().equals("finished-splits-state"))
+ .findFirst();
+
+ assertThat(stateSplitOptional)
+ .isPresent()
+ .hasValueSatisfying(
+ stateSplit -> {
+ NavigableMap<Long, Set<String>> finishedSplitsMap =
+ stateSplit.getFinishedSplitsMap();
+
assertThat(finishedSplitsMap).hasSize(1).containsKey(1L);
+
assertThat(finishedSplitsMap.get(1L)).contains(split.splitId());
+ });
+
+ // Find and verify the original split
+ Optional<DynamoDbStreamsShardSplit> originalSplitOptional =
+ snapshotSplits.stream()
+ .filter(s -> s.getShardId().equals(split.getShardId()))
+ .findFirst();
+
+ assertThat(originalSplitOptional)
+ .isPresent()
+ .hasValueSatisfying(
+ originalSplit ->
+ assertThat(originalSplit)
+ .usingRecursiveComparison()
+ .isEqualTo(split));
Review Comment:
agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
