gguptp commented on code in PR #193:
URL:
https://github.com/apache/flink-connector-aws/pull/193#discussion_r2014047414
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/split/DynamoDbStreamsShardSplit.java:
##########
@@ -40,12 +40,22 @@ public final class DynamoDbStreamsShardSplit implements
SourceSplit {
private final String shardId;
private final StartingPosition startingPosition;
private final String parentShardId;
+ private final long finishedAfterCheckpoint;
Review Comment:
i would think finishedAfterCheckpoint is more accurate since the issue
occurs when we restarted the job just after checkpoint and the reader state is
up-to-date but enumerator's is not
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/split/DynamoDbStreamsShardSplit.java:
##########
@@ -40,12 +40,22 @@ public final class DynamoDbStreamsShardSplit implements
SourceSplit {
private final String shardId;
private final StartingPosition startingPosition;
private final String parentShardId;
+ private final long finishedAfterCheckpoint;
Review Comment:
i would say finishedAfterCheckpoint is more accurate since the issue occurs
when we restarted the job just after checkpoint and the reader state is
up-to-date but enumerator's is not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
