leekeiabstraction commented on code in PR #193:
URL:
https://github.com/apache/flink-connector-aws/pull/193#discussion_r2014072074
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/split/DynamoDbStreamsShardSplit.java:
##########
@@ -40,12 +40,22 @@ public final class DynamoDbStreamsShardSplit implements
SourceSplit {
private final String shardId;
private final StartingPosition startingPosition;
private final String parentShardId;
+ private final long finishedAfterCheckpoint;
Review Comment:
I agree that a restart is necessary for the reader to lose track of shards.
However, the checkpoint still would cause the issue even if a restart does not
occur, for example when resuming from an checkpoint/savepoint. The crux of the
issue is not that shardSplit finished after checkpointing or a restart
happened, but rather that shardSplit happened before reader completed
checkpointing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
