davidradl commented on code in PR #26348:
URL: https://github.com/apache/flink/pull/26348#discussion_r2012554501
##########
flink-metrics/flink-metrics-otel/pom.xml:
##########
@@ -143,4 +143,39 @@ under the License.
</dependency>
</dependencies>
+
+ <build>
Review Comment:
@mateczagany thank you for your quick response. Yes I see it may not be too
easy to do this as a unit test.
How about adding something to flink-examples so that it would be built as
part of the Flink build that could test that the dependancies are expected.
Maybe a simplified version of the open telemetry code that you saw the issue
with would be a good candidate. We could track this in another Jira though it
is preferable to have the test code go in with the change it is testing. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
