mateczagany commented on code in PR #26348:
URL: https://github.com/apache/flink/pull/26348#discussion_r2012856271
##########
flink-metrics/flink-metrics-otel/pom.xml:
##########
@@ -143,4 +143,40 @@ under the License.
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>shade-flink</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <artifactSet>
+ <includes>
+
<include>io.opentelemetry:*</include>
+
<include>com.squareup.okhttp3:*</include>
+
<include>com.squareup.okio:*</include>
+ </includes>
+ </artifactSet>
+ <relocations>
+ <relocation>
+
<pattern>okhttp3/internal/publicsuffix</pattern>
Review Comment:
This needs to be relocated so that `ApacheNoticeResourceTransformer` can
pick it up and there won't be multiple NOTICE files in the package.
It's done the same way in `flink-kubernetes` and `flink-metrics-datadog`.
However, in `flink-metrics-influxdb`, this file is simply removed from the
result JAR file, not relocated, and its content was added to the NOTICE file
manually there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
