Poorvankbhatia commented on code in PR #26274: URL: https://github.com/apache/flink/pull/26274#discussion_r2027548013
########## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/SimpleBatchCreator.java: ########## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.base.sink.writer; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.connector.base.sink.writer.strategy.RequestInfo; +import org.apache.flink.util.Preconditions; + +import java.io.Serializable; +import java.util.ArrayList; +import java.util.List; + +/** + * A simple implementation of {@link BatchCreator} that forms a batch by taking up to {@code + * requestInfo.getBatchSize()} entries from the head of the buffer, so long as the cumulative size + * in bytes does not exceed the configured maximum. + * + * <p>This strategy stops gathering entries from the buffer as soon as adding the next entry would + * exceed the {@code maxBatchSizeInBytes}, or once it has collected {@code + * requestInfo.getBatchSize()} entries, whichever occurs first. + * + * @param <RequestEntryT> the type of request entries managed by this batch creator + */ +@PublicEvolving Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
