fredia commented on code in PR #26394: URL: https://github.com/apache/flink/pull/26394#discussion_r2030376994
########## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/snapshot/ForStNativeFullSnapshotStrategy.java: ########## @@ -203,6 +205,7 @@ public ForStNativeSnapshotResources syncPrepareResources(long checkpointId) thro backendUID, checkpointId); db.enableFileDeletions(false); + lease.close(); Review Comment: No, because we should close `lease` in `releaser`, and the `releaser` may be invoked after `finally clause`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org