fredia commented on code in PR #26394:
URL: https://github.com/apache/flink/pull/26394#discussion_r2030377995
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStKeyedStateBackend.java:
##########
@@ -510,6 +519,14 @@ public void dispose() {
if (this.disposed) {
return;
}
+ // This call will block until all clients that still acquire
access to the ForSt
Review Comment:
> still acquire access -> still have the lock
no, it's about `resource guard`, not `lock`.
> the comment formatting is strange - it is split of many lines.
The spotless did this format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
