Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3039#discussion_r93816451
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -566,17 +574,13 @@ object TableEnvironment {
def getFieldTypes(inputType: TypeInformation[_]):
Array[TypeInformation[_]] = {
validateType(inputType)
- inputType match {
- case t: TupleTypeInfo[_] => getTypes(t)
- case c: CaseClassTypeInfo[_] => getTypes(c)
- case p: PojoTypeInfo[_] => getTypes(p)
- case r: RowTypeInfo => getTypes(r)
- case tpe =>
- throw new TableException(s"Type $tpe lacks explicit field naming")
+ getFieldNames(inputType).map { i =>
--- End diff --
I think this maybe error-prone. Field types array should be mapped by
indices not field names. Such as PojoType filed names' order is not equal to
field types' order. The original code in `UserDefinedFunctionUtil.getFieldInfo`
maybe wrong too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
