Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3039#discussion_r93943868
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java
---
@@ -111,24 +112,17 @@
return kafkaSource;
}
- @Override
- public int getNumberOfFields() {
- return fieldNames.length;
- }
-
- @Override
public String[] getFieldsNames() {
- return fieldNames;
+ return TableSource$class.getFieldsNames(this);
--- End diff --
Hi,
I'm not sure about implementing this as a Scala trait with implemented
methods. IMO, this makes it much harder to implement TableSources in Java (esp.
for users who are not familiar with Scala and its implications).
What do you think about implementing `TableSource` as abstract class and
providing three other abstract classes that extend `TableSource` with the
batch, the stream, and both interfaces?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
