Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3039#discussion_r93816695
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSource.scala
---
@@ -26,24 +26,24 @@ import org.apache.flink.table.api.TableEnvironment
* Schema information consists of a data type, field names, and
corresponding indices of
* these names in the data type.
*
- * To define a TableSource one need to implement
[[TableSource.getReturnType]]. In this case
- * field names and field indices are deducted from the returned type.
+ * To define a TableSource one need to implement
[[TableSource#getReturnType]]. In this case
+ * field names and field indices are derived from the returned type.
*
* In case if custom field names are required one need to implement both
- * [[TableSource.getFieldsNames]] and [[TableSource.getFieldsIndices]].
+ * [[TableSource#getFieldsNames]] and [[TableSource#getFieldsIndices]].
*
* @tparam T The return type of the [[TableSource]].
*/
trait TableSource[T] {
/** Returns the names of the table fields. */
def getFieldsNames: Array[String] = {
- TableEnvironment.getFieldInfo(getReturnType)._1
+ TableEnvironment.getFieldNames(getReturnType)
}
/** Returns the indices of the table fields. */
- def getFieldsIndices: Array[Int] = {
- getFieldsNames.indices.toArray
+ def getFieldsIndexes: Array[Int] = {
--- End diff --
The plural of index should be indices.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
