[
https://issues.apache.org/jira/browse/FLINK-5280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802752#comment-15802752
]
ASF GitHub Bot commented on FLINK-5280:
---------------------------------------
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/3039
Hi @fhueske, @wuchong
I think we can solve the problem with current `TableSource` class hierarchy
in a different way. If we remove all abstract classes and move all default
implementations in `TableSource` trait it will make class hierarchy much
simpler. The only drawback of this is that Java users will need to provide
implementations of trait methods that explicitly [call default
implementations](http://stackoverflow.com/a/7637888).
I don't think this bad since it's a common way to extend Scala traits. We
can additionally remove `getFieldNames` and `getFieldIndices` if you think they
are superfluous. But I don't think there is a big difference.
What do you think @fhueske, @wuchong ?
> Extend TableSource to support nested data
> -----------------------------------------
>
> Key: FLINK-5280
> URL: https://issues.apache.org/jira/browse/FLINK-5280
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.2.0
> Reporter: Fabian Hueske
> Assignee: Ivan Mushketyk
>
> The {{TableSource}} interface does currently only support the definition of
> flat rows.
> However, there are several storage formats for nested data that should be
> supported such as Avro, Json, Parquet, and Orc. The Table API and SQL can
> also natively handle nested rows.
> The {{TableSource}} interface and the code to register table sources in
> Calcite's schema need to be extended to support nested data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
