[
https://issues.apache.org/jira/browse/FLINK-5280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804281#comment-15804281
]
ASF GitHub Bot commented on FLINK-5280:
---------------------------------------
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/3039
I don't think we will win a lot with this. Even if we remove these two
methods from the `TableSource` trait interface there is still `getTypeIndices`
method and Java users will have to call it if they are going to implement a
`TableSource` trait. And if a user knows how to inherit a trait with one method
he/she will be able to inherit a trait with three methods.
The second problem with this approach is that it's not really
Object-Oriented. We will have to rely on reflection tricks (probably sugared
with pattern matching) while we simply having three methods is more clean OO
solution.
What if we leave all three methods and simply add some base Java
implementations that already implement these traits? Something like
`JavaBatchTableSource`, `JavaStreamTableSource`, and
`JavaBatchStreamTableSource`? Then users will not need to struggle with the
traits inheritance issues.
> Extend TableSource to support nested data
> -----------------------------------------
>
> Key: FLINK-5280
> URL: https://issues.apache.org/jira/browse/FLINK-5280
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.2.0
> Reporter: Fabian Hueske
> Assignee: Ivan Mushketyk
>
> The {{TableSource}} interface does currently only support the definition of
> flat rows.
> However, there are several storage formats for nested data that should be
> supported such as Avro, Json, Parquet, and Orc. The Table API and SQL can
> also natively handle nested rows.
> The {{TableSource}} interface and the code to register table sources in
> Calcite's schema need to be extended to support nested data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
