alnzng commented on code in PR #122: URL: https://github.com/apache/flink-agents/pull/122#discussion_r2288994582
########## python/flink_agents/api/core_options.py: ########## @@ -0,0 +1,52 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################# +from typing import Any + +from pyflink.java_gateway import get_gateway + +from flink_agents.api.configuration import ConfigOption + + +def covert_j_option_to_python_option(j_option: Any) -> ConfigOption: Review Comment: Nit: I would suggest we keep the naming consistent. If we prefer short names(e.g. j -> java), let's do it for python as well(e.g. p -> python). Or versa vice. ########## api/src/main/java/org/apache/flink/agents/api/FlinkAgentsCoreOptions.java: ########## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.agents.api; + +import org.apache.flink.configuration.ConfigOption; +import org.apache.flink.configuration.ConfigOptions; + +public final class FlinkAgentsCoreOptions { + public static final ConfigOption<String> EXAMPLE_OPTION = Review Comment: +1 on this. For educating purpose, I would suggest we add javadoc to explain the usage of this class, instead of using this placeholder field. A clarification quesiton: - is this class intended for defining all FlinkAgents options? or this is only for `core` options and we expected there could be some `non-core` options -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
