GreatEugenius commented on code in PR #122:
URL: https://github.com/apache/flink-agents/pull/122#discussion_r2292614911


##########
python/flink_agents/runtime/remote_execution_environment.py:
##########
@@ -133,10 +138,26 @@ class 
RemoteExecutionEnvironment(AgentsExecutionEnvironment):
     """Implementation of AgentsExecutionEnvironment for execution with 
DataStream."""
 
     __env: StreamExecutionEnvironment
+    __config: LocalConfiguration
 
     def __init__(self, env: StreamExecutionEnvironment) -> None:
         """Init method of RemoteExecutionEnvironment."""
         self.__env = env
+        self.__config = LocalConfiguration()
+        flink_conf_dir = os.environ.get("FLINK_CONF_DIR")
+        if flink_conf_dir is not None:
+            config_dir = Path(flink_conf_dir) / "config.yaml"

Review Comment:
   No, currently flink-agents depends on Flink 1.20 and uses config.yaml as the 
configuration file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to