Sxnan commented on code in PR #122: URL: https://github.com/apache/flink-agents/pull/122#discussion_r2302687459
########## api/src/main/java/org/apache/flink/agents/api/configuration/FullConfiguration.java: ########## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.flink.agents.api.configuration; + +/** + * A configuration interface that provides both read and write access. Combines the capabilities of + * {@link ReadableConfiguration} and {@link WritableConfiguration}. + */ +public interface FullConfiguration extends ReadableConfiguration, WritableConfiguration {} Review Comment: We can just name it `Configuration` ########## python/flink_agents/plan/resource_provider.py: ########## @@ -99,11 +99,11 @@ def provide(self, get_resource: Callable, config: AgentConfiguration) -> Resourc final_kwargs = {} - clazz_kwargs = config.get_config_data_by_prefix(self.clazz) + resource_class_config = config.get_config_data_by_prefix(self.clazz) resource_kwargs = config.get_config_data_by_prefix(self.name) final_kwargs.update(self.kwargs) - final_kwargs.update(clazz_kwargs) + final_kwargs.update(resource_class_config) final_kwargs.update(resource_kwargs) Review Comment: resource_kwargs -> resource_config ########## api/src/main/java/org/apache/flink/agents/api/configuration/ReadableConfiguration.java: ########## @@ -26,7 +26,16 @@ public interface ReadableConfiguration { * @param defaultValue The default value to return if key is not found * @return The integer value associated with the key or the default value */ - int getInt(String key, Integer defaultValue); + int getInt(String key, int defaultValue); Review Comment: Should we use `Integer` instead of `int` so that we can have a null default value. Same for the other getter. For setter, it is fine to use the `int`, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
