[
https://issues.apache.org/jira/browse/FLINK-4692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817986#comment-15817986
]
ASF GitHub Bot commented on FLINK-4692:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2938#discussion_r95552283
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -517,22 +657,20 @@ object AggregateUtil {
private def createAggregateBufferDataType(
groupings: Array[Int],
aggregates: Array[Aggregate[_]],
- inputType: RelDataType): RowTypeInfo = {
+ inputType: RelDataType,
+ windowKeyType: Option[TypeInformation[_]] = None): RowTypeInfo = {
// get the field data types of group keys.
val groupingTypes: Seq[TypeInformation[_]] = groupings
.map(inputType.getFieldList.get(_).getType)
.map(FlinkTypeFactory.toTypeInfo)
- val aggPartialNameSuffix = "agg_buffer_"
- val factory = new SqlTypeFactoryImpl(RelDataTypeSystem.DEFAULT)
-
// get all field data types of all intermediate aggregates
val aggTypes: Seq[TypeInformation[_]] =
aggregates.flatMap(_.intermediateDataType)
// concat group key types and aggregation types
--- End diff --
Update comment.
> Add tumbling group-windows for batch tables
> -------------------------------------------
>
> Key: FLINK-4692
> URL: https://issues.apache.org/jira/browse/FLINK-4692
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Jark Wu
>
> Add Tumble group-windows for batch tables as described in
> [FLIP-11|https://cwiki.apache.org/confluence/display/FLINK/FLIP-11%3A+Table+API+Stream+Aggregations].
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
