[ 
https://issues.apache.org/jira/browse/FLINK-4692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817988#comment-15817988
 ] 

ASF GitHub Bot commented on FLINK-4692:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2938#discussion_r94943939
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/groupWindows.scala
 ---
    @@ -107,7 +121,8 @@ case class EventTimeTumblingGroupWindow(
         super.validate(tableEnv)
           .orElse(TumblingGroupWindow.validate(tableEnv, size))
           .orElse(size match {
    -        case Literal(_, RowIntervalTypeInfo.INTERVAL_ROWS) =>
    +        case Literal(_, RowIntervalTypeInfo.INTERVAL_ROWS)
    +          if tableEnv.isInstanceOf[StreamTableEnvironment] =>
               ValidationFailure(
                 "Event-time grouping windows on row intervals are currently 
not supported.")
    --- End diff --
    
    I would add "in a stream environment" to this and the other change.


> Add tumbling group-windows for batch tables
> -------------------------------------------
>
>                 Key: FLINK-4692
>                 URL: https://issues.apache.org/jira/browse/FLINK-4692
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Jark Wu
>
> Add Tumble group-windows for batch tables as described in 
> [FLIP-11|https://cwiki.apache.org/confluence/display/FLINK/FLIP-11%3A+Table+API+Stream+Aggregations].
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to