[ 
https://issues.apache.org/jira/browse/FLINK-4692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15820239#comment-15820239
 ] 

ASF GitHub Bot commented on FLINK-4692:
---------------------------------------

Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2938#discussion_r95728469
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
 ---
    @@ -591,5 +729,27 @@ object AggregateUtil {
     
         groupingOffsetMapping.toArray
       }
    +
    +  private def getTimeFieldPosition(timeField: Expression, inputType: 
RelDataType): Int = {
    +    timeField match {
    +      case ResolvedFieldReference(name, resultType) =>
    +        // get the RelDataType referenced by the time-field
    +        val relDataType = inputType.getFieldList.filter(r => 
name.equals(r.getName))
    --- End diff --
    
    We set `Lex.JAVA` as default lexical policy which is case-sensitive. I will 
change this logical to adapt case-sensitive or insensitive. So that it works 
when user customize lexical policy.


> Add tumbling group-windows for batch tables
> -------------------------------------------
>
>                 Key: FLINK-4692
>                 URL: https://issues.apache.org/jira/browse/FLINK-4692
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Jark Wu
>
> Add Tumble group-windows for batch tables as described in 
> [FLIP-11|https://cwiki.apache.org/confluence/display/FLINK/FLIP-11%3A+Table+API+Stream+Aggregations].
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to