JTaky commented on code in PR #27101:
URL: https://github.com/apache/flink/pull/27101#discussion_r2420492102
##########
flink-filesystems/flink-gs-fs-hadoop/src/main/java/org/apache/flink/fs/gs/storage/GSBlobStorageImpl.java:
##########
@@ -61,7 +61,8 @@ public GSBlobStorage.WriteChannel writeBlob(GSBlobIdentifier
blobIdentifier) {
Preconditions.checkNotNull(blobIdentifier);
BlobInfo blobInfo =
BlobInfo.newBuilder(blobIdentifier.getBlobId()).build();
- com.google.cloud.WriteChannel writeChannel = storage.writer(blobInfo);
+ com.google.cloud.WriteChannel writeChannel =
Review Comment:
We can wrap the storage in the UT and ensure that proper option is passed.
For this we need to extend the
[Storage](https://github.com/googleapis/java-storage/blob/9dcce11a7f5197efc984c9cbdfe1fbcb25d6a159/google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java#L92).
Which is for InternalExtensionOnly.
Some e2e would be great to have, but from what I understand only Azure is
available in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
