JTaky commented on code in PR #27101:
URL: https://github.com/apache/flink/pull/27101#discussion_r2465734695
##########
flink-filesystems/flink-gs-fs-hadoop/src/main/java/org/apache/flink/fs/gs/storage/GSBlobStorageImpl.java:
##########
@@ -61,7 +61,8 @@ public GSBlobStorage.WriteChannel writeBlob(GSBlobIdentifier
blobIdentifier) {
Preconditions.checkNotNull(blobIdentifier);
BlobInfo blobInfo =
BlobInfo.newBuilder(blobIdentifier.getBlobId()).build();
- com.google.cloud.WriteChannel writeChannel = storage.writer(blobInfo);
+ com.google.cloud.WriteChannel writeChannel =
Review Comment:
@davidradl thanks for challenging. I have reconsidered approach and added
some tests, for functionality. As result the new test dependency to emulate GS
Storage is added.
This test dependency doesn't allow to use versioning, so I cannot test the
atomicity of the operations, meanwhile happy paths are added to test write and
compose methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
