JTaky commented on code in PR #27101:
URL: https://github.com/apache/flink/pull/27101#discussion_r2421005485
##########
flink-filesystems/flink-gs-fs-hadoop/src/main/java/org/apache/flink/fs/gs/storage/GSBlobStorageImpl.java:
##########
@@ -61,7 +61,8 @@ public GSBlobStorage.WriteChannel writeBlob(GSBlobIdentifier
blobIdentifier) {
Preconditions.checkNotNull(blobIdentifier);
BlobInfo blobInfo =
BlobInfo.newBuilder(blobIdentifier.getBlobId()).build();
- com.google.cloud.WriteChannel writeChannel = storage.writer(blobInfo);
+ com.google.cloud.WriteChannel writeChannel =
Review Comment:
Tried briefly to make some UT and without mocking it is hard. Currently
GSBlobStorageImpl is too low level and it is the component which is being
mocked in the codebase.
Creating a TestStorage to catch GCP calls is also hard, notable because some
of the methods returns Blob object, which cannot be created without reflections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
