Au-Miner commented on code in PR #27099:
URL: https://github.com/apache/flink/pull/27099#discussion_r2438941733
##########
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/deltajoin/StreamingDeltaJoinOperatorTest.java:
##########
@@ -697,6 +948,38 @@ private static void insertTableData(StreamRecord<RowData>
record, boolean insert
}
}
+ private <T> Map<RowData, T> newHashMap(RowData key, T value) {
+ return newHashMap(Collections.singletonList(key),
Collections.singletonList(value));
+ }
+
+ private <T> Map<RowData, T> newHashMap(RowData key1, T value1, RowData
key2, T value2) {
+ return newHashMap(Arrays.asList(key1, key2), Arrays.asList(value1,
value2));
+ }
+
+ private <T> Map<RowData, T> newHashMap(
+ RowData key1, T value1, RowData key2, T value2, RowData key3, T
value3) {
+ return newHashMap(Arrays.asList(key1, key2, key3),
Arrays.asList(value1, value2, value3));
+ }
Review Comment:
Should we replace these three functions with functions using Object... obj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
