xuyangzhong commented on code in PR #27099:
URL: https://github.com/apache/flink/pull/27099#discussion_r2419122968
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java:
##########
@@ -725,6 +725,32 @@ public class ExecutionConfigOptions {
"Set whether to use the SQL/Table operators based
on the asynchronous state api. "
+ "Default value is false.");
+ @Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+ public static final ConfigOption<Boolean>
TABLE_EXEC_DELTA_JOIN_CACHE_ENABLED =
+ key("table.exec.delta-join.cache-enabled")
+ .booleanType()
+ .defaultValue(true)
+ .withDescription(
+ "Whether enable the cache of delta join. If
enabled, the delta join would cache the records from remote dim table.");
Review Comment:
How about updating this comment to `Whether to enable the cache of delta
join. If enabled, the delta join caches the records from remote dim table.
Default is true.` to align with other configs like
`TABLE_EXEC_SORT_ASYNC_MERGE_ENABLED`, `TABLE_EXEC_SPILL_COMPRESSION_ENABLED`,
...?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
