davidradl commented on code in PR #27099:
URL: https://github.com/apache/flink/pull/27099#discussion_r2419060569
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java:
##########
@@ -725,6 +725,32 @@ public class ExecutionConfigOptions {
"Set whether to use the SQL/Table operators based
on the asynchronous state api. "
+ "Default value is false.");
+ @Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+ public static final ConfigOption<Boolean>
TABLE_EXEC_DELTA_JOIN_CACHE_ENABLED =
+ key("table.exec.delta-join.cache-enabled")
+ .booleanType()
+ .defaultValue(true)
Review Comment:
Hhat is your thinking to have a the default as true, I assume this is
changing the existing non caching behaviour. It would make more sense to me to
have the users opt into the caching and having the default as false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
