[
https://issues.apache.org/jira/browse/FLINK-5452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15820582#comment-15820582
]
ASF GitHub Bot commented on FLINK-5452:
---------------------------------------
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3095
Thanks for looking into this issue @KurtYoung
I agree that this is rather an issue with the tests and not with the actual
code. However, I would fix the tests a bit differently.
The goal of the code that you removed was to validate that each partition
is correctly sorted and that the partitions themselves are correctly sorted,
i.e., for a descending sort, the highest values should be in partition 0 and
the lowest in partition n.
In order to ensure parallel execution, we cannot execute the sort tests in
a collection environment but need a cluster environment. Moreover, we should
explicitly set a default parallelism on the ExecutionEnvironment to avoid that
the program is executed with parallelism 1 (a parallelism of 3 should suffice).
Once we do that we must ensure that the started minicluster offers enough slots
to run the program.
I'll add a few more inline comments to the tests.
Thanks, Fabian
> Make table unit tests pass under cluster mode
> ---------------------------------------------
>
> Key: FLINK-5452
> URL: https://issues.apache.org/jira/browse/FLINK-5452
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Kurt Young
> Assignee: Kurt Young
>
> Currently if we change the test execution mode to
> {{TestExecutionMode.CLUSTER}} in {{TableProgramsTestBase}}, some cases will
> fail. Need to figure out whether it's the case design problem or there are
> some bugs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
