[
https://issues.apache.org/jira/browse/FLINK-5452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15820593#comment-15820593
]
ASF GitHub Bot commented on FLINK-5452:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3095#discussion_r95754128
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/table/SortITCase.scala
---
@@ -57,14 +57,8 @@ class SortITCase(
- x.productElement(0).asInstanceOf[Int] )
val expected = sortExpectedly(tupleDataSetStrings)
- val results = t.toDataSet[Row].mapPartition(rows =>
Seq(rows.toSeq)).collect()
-
- val result = results
- .filterNot(_.isEmpty)
- .sortBy(_.head)(Ordering.by(f=> f.toString))
--- End diff --
We should change this to ` .sortBy(_.head)` and provide an implicit
ordering for `Row`.
When we changed `Row` to not extend `Product`, we should have added the
implicit ordering for `Row` instead of sorting by String.
The same applies to the other tests in this class.
> Make table unit tests pass under cluster mode
> ---------------------------------------------
>
> Key: FLINK-5452
> URL: https://issues.apache.org/jira/browse/FLINK-5452
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Kurt Young
> Assignee: Kurt Young
>
> Currently if we change the test execution mode to
> {{TestExecutionMode.CLUSTER}} in {{TableProgramsTestBase}}, some cases will
> fail. Need to figure out whether it's the case design problem or there are
> some bugs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
