ferenc-csaky commented on code in PR #5:
URL:
https://github.com/apache/flink-connector-http/pull/5#discussion_r2499309332
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/table/sink/Slf4jHttpPostRequestCallback.java:
##########
@@ -45,25 +42,22 @@ public void call(
String endpointUrl,
Map<String, String> headerMap) {
- String requestBody =
- requestEntry.getElements().stream()
- .map(element -> new String(element,
StandardCharsets.UTF_8))
- .collect(Collectors.joining());
+ // Uncomment if you want to see the requestBody in the log
Review Comment:
maybe introduce a config option flag for this? it should be turned off by
default and the desc should emphasize this may add sensitive information to the
logs, so use it with caution. but then to activate it it won't require manual
recompile and JAR patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
