davidradl commented on code in PR #5:
URL:
https://github.com/apache/flink-connector-http/pull/5#discussion_r2504032343
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/table/sink/Slf4jHttpPostRequestCallback.java:
##########
@@ -45,25 +42,22 @@ public void call(
String endpointUrl,
Map<String, String> headerMap) {
- String requestBody =
- requestEntry.getElements().stream()
- .map(element -> new String(element,
StandardCharsets.UTF_8))
- .collect(Collectors.joining());
+ // Uncomment if you want to see the requestBody in the log
Review Comment:
@ferenc-csaky We have been thinking about this and propose that we have a
config option, http-logging, that have 3 values
min- the default, no content from requests responses and headers.
reqresps - requests and responses
max - requests, responses and headers
I think this is in line with your feedback - let me know if you have any
concerns. In the meantime I will implement this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
