davidradl commented on code in PR #5:
URL:
https://github.com/apache/flink-connector-http/pull/5#discussion_r2499465784
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/table/sink/Slf4jHttpPostRequestCallback.java:
##########
@@ -45,25 +42,22 @@ public void call(
String endpointUrl,
Map<String, String> headerMap) {
- String requestBody =
- requestEntry.getElements().stream()
- .map(element -> new String(element,
StandardCharsets.UTF_8))
- .collect(Collectors.joining());
+ // Uncomment if you want to see the requestBody in the log
Review Comment:
@ferenc-csaky thanks for your feedback. I see the options as :
1. If we had a configuration option say `http-extended-tracing` we could
put out the headers , request and response. The authentication header content
and other headers are very sensitive.
2. If we had a configuration option say `http-extended-tracing` we could
put out the header keys, request and response as the authentication header
content and other headers are very sensitive. The authentication header content
and other headers are very sensitive.
3. If we had a configuration option say `http-extended-tracing` we could
put out just the request and responses
4. The jar file does need to be recompiled or patched, but you need to
supply a new jar file which overrides this callback. I could supply a sample
with the code to do this.
4. Is very safe, being most risk averse I would go 4, then 2 or 3, no keen
on 1. What are your thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
