davidradl commented on code in PR #27265:
URL: https://github.com/apache/flink/pull/27265#discussion_r2556341560
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##########
@@ -2404,20 +2404,7 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL)
BuiltInFunctionDefinition.newBuilder()
.name("TO_TIMESTAMP_LTZ")
.kind(SCALAR)
- .inputTypeStrategy(
- or(
-
sequence(logical(LogicalTypeFamily.CHARACTER_STRING)),
- sequence(
-
logical(LogicalTypeFamily.CHARACTER_STRING),
-
logical(LogicalTypeFamily.CHARACTER_STRING)),
- sequence(
-
logical(LogicalTypeFamily.CHARACTER_STRING),
-
logical(LogicalTypeFamily.CHARACTER_STRING),
-
logical(LogicalTypeFamily.CHARACTER_STRING)),
-
sequence(logical(LogicalTypeFamily.NUMERIC)),
Review Comment:
The SpecificInputTypeStrategies seems to only process when the first
parameter is a string. I am wondering about the last 2 entries in this list
that start with numbers. I am curious , have we lost support for these patterns
with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
