snuyanzin commented on code in PR #27265: URL: https://github.com/apache/flink/pull/27265#discussion_r2556837218
########## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ToTimestampLtzInputTypeStrategy.java: ########## @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.types.inference.strategies; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.functions.BuiltInFunctionDefinitions; +import org.apache.flink.table.functions.FunctionDefinition; +import org.apache.flink.table.types.DataType; +import org.apache.flink.table.types.inference.ArgumentCount; +import org.apache.flink.table.types.inference.ArgumentTypeStrategy; +import org.apache.flink.table.types.inference.CallContext; +import org.apache.flink.table.types.inference.ConstantArgumentCount; +import org.apache.flink.table.types.inference.InputTypeStrategy; +import org.apache.flink.table.types.inference.Signature; +import org.apache.flink.table.types.inference.Signature.Argument; +import org.apache.flink.table.types.logical.LogicalTypeFamily; + +import java.time.DateTimeException; +import java.time.ZoneId; +import java.time.format.DateTimeFormatter; +import java.util.ArrayList; +import java.util.List; +import java.util.Optional; + +import static org.apache.flink.table.types.inference.InputTypeStrategies.logical; +import static org.apache.flink.table.types.inference.InputTypeStrategies.or; +import static org.apache.flink.table.types.inference.InputTypeStrategies.sequence; + +/** + * A strategy for {@link BuiltInFunctionDefinitions#TO_TIMESTAMP_LTZ} where the first argument is a + * string that needs to be parsed. + */ +@Internal +public class ToTimestampLtzInputTypeStrategy implements InputTypeStrategy { + + private static final ArgumentTypeStrategy CHARACTER_STRING_FAMILY_ARG = Review Comment: To double check: am I right that this will do checks only in planning it means it will not catch cases like this ```sql SELECT to_timestamp_ltz('1000-01-01 00:00:00', pattern, 'UTC') FROM (VALUES('unparsable')) AS t(pattern); ``` ########## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ToTimestampLtzInputTypeStrategy.java: ########## @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.types.inference.strategies; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.functions.BuiltInFunctionDefinitions; +import org.apache.flink.table.functions.FunctionDefinition; +import org.apache.flink.table.types.DataType; +import org.apache.flink.table.types.inference.ArgumentCount; +import org.apache.flink.table.types.inference.ArgumentTypeStrategy; +import org.apache.flink.table.types.inference.CallContext; +import org.apache.flink.table.types.inference.ConstantArgumentCount; +import org.apache.flink.table.types.inference.InputTypeStrategy; +import org.apache.flink.table.types.inference.Signature; +import org.apache.flink.table.types.inference.Signature.Argument; +import org.apache.flink.table.types.logical.LogicalTypeFamily; + +import java.time.DateTimeException; +import java.time.ZoneId; +import java.time.format.DateTimeFormatter; +import java.util.ArrayList; +import java.util.List; +import java.util.Optional; + +import static org.apache.flink.table.types.inference.InputTypeStrategies.logical; +import static org.apache.flink.table.types.inference.InputTypeStrategies.or; +import static org.apache.flink.table.types.inference.InputTypeStrategies.sequence; + +/** + * A strategy for {@link BuiltInFunctionDefinitions#TO_TIMESTAMP_LTZ} where the first argument is a + * string that needs to be parsed. + */ +@Internal +public class ToTimestampLtzInputTypeStrategy implements InputTypeStrategy { + + private static final ArgumentTypeStrategy CHARACTER_STRING_FAMILY_ARG = Review Comment: To double check: am I right that this will do checks only in planning it means it will not catch cases like this ```sql SELECT to_timestamp_ltz('1000-01-01 00:00:00', pattern, 'UTC') FROM (VALUES('unparsable')) AS t(pattern); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
