davidradl commented on code in PR #27265:
URL: https://github.com/apache/flink/pull/27265#discussion_r2559231787
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##########
@@ -2404,20 +2404,7 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL)
BuiltInFunctionDefinition.newBuilder()
.name("TO_TIMESTAMP_LTZ")
.kind(SCALAR)
- .inputTypeStrategy(
- or(
-
sequence(logical(LogicalTypeFamily.CHARACTER_STRING)),
- sequence(
-
logical(LogicalTypeFamily.CHARACTER_STRING),
-
logical(LogicalTypeFamily.CHARACTER_STRING)),
- sequence(
-
logical(LogicalTypeFamily.CHARACTER_STRING),
-
logical(LogicalTypeFamily.CHARACTER_STRING),
-
logical(LogicalTypeFamily.CHARACTER_STRING)),
-
sequence(logical(LogicalTypeFamily.NUMERIC)),
Review Comment:
@dawidwys I see now, I was mislead by the
[comments](https://github.com/apache/flink/blob/1cc2f147ddf0ffd4ce37be7c6f55355cf34fa907/flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ToTimestampLtzInputTypeStrategy.java#L46)
```
* A strategy for {@link BuiltInFunctionDefinitions#TO_TIMESTAMP_LTZ} where
the first argument is a
* string that needs to be parsed.
```
But in reality, if it is does not get a string it processes the numerics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
