mateczagany commented on code in PR #27469:
URL: https://github.com/apache/flink/pull/27469#discussion_r2745031495
##########
flink-rpc/flink-rpc-akka/pom.xml:
##########
@@ -186,6 +186,8 @@ under the License.
<!-- Only parts of NOTICE file actually apply to the netty JAR and have been
manually
copied into this modules's NOTICE file. -->
<exclude>META-INF/NOTICE.txt</exclude>
+
<!-- Only .class files from flink-shaded-netty should be loaded, so don't
package any to flink-rpc-akka jar. -->
+
<exclude>**/*.class</exclude>
Review Comment:
The issue here was that some Netty classes required by Pekko were not
properly shaded as `netty-codec` was
[reworked](https://github.com/netty/netty/wiki/Netty-4.2-Migration-Guide#lesser-compatibility-changes)
in the latest Netty release. Not sure why, but depending on `netty-all` will
result in a lot of classes, such as `LengthFieldPrepender` not being included
in the shading step.
My idea here was to not package any shaded Netty dependencies from this
module, and instead only use the already shaded classes from
`flink-shaded-netty`. This would be inconsistent compared to how this module
worked before, so I've gone with another fix:
- Depend only on Netty dependencies that are required by Pekko (this reduces
the amount of dependencies and fixes the shading issue mentioned)
- Update licenses, as they were quite outdated.
I think this makes the most sense, as we don't need *ALL* of Netty
dependencies coming from `netty-all`, as we can be quite certain of what Pekko
actually needs by looking at [their
dependencies](https://github.com/apache/pekko/blob/2884b12f06df09a38040add82e78361dcb5c51c2/project/Dependencies.scala#L67).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
