wenjin272 commented on code in PR #525:
URL: https://github.com/apache/flink-agents/pull/525#discussion_r2786430311
##########
python/pyproject.toml:
##########
@@ -55,7 +55,6 @@ dependencies = [
"anthropic>=0.64.0",
"chromadb==1.0.21",
"onnxruntime<1.24.1;python_version<'3.11'",
- "onnxruntime>=1.24.1;python_version>='3.11'",
Review Comment:
> > uv will also use onnxruntime==1.23.2, even if onnxruntime==1.24.1 is
available.
>
> @wenjin272 Did you notice this in your local env or CI? Have you tried to
remove `.env` folder and uv lock to start with a fresh build?
>
> I currently don't have ARM version Python installed on my (Company)laptop,
I can check if installing ARM version Python is accpetable in my side.
I noticed this both in my local env and CI, even if I remove the uv lock or
try uv sync --upgrade.
For example, in ut test for python 3.11 on macos for this pr:
https://github.com/apache/flink-agents/actions/runs/21851853229/job/63068025146?pr=525,
the installed onnxruntime is 1.23.2
<img width="926" height="456" alt="image"
src="https://github.com/user-attachments/assets/0ebe4d5a-e722-4f2a-88d3-53daa925c07f";
/>
It actually won't cause any failure, but may be unexpected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
