alnzng commented on code in PR #525:
URL: https://github.com/apache/flink-agents/pull/525#discussion_r2789631433
##########
python/pyproject.toml:
##########
@@ -55,7 +55,6 @@ dependencies = [
"anthropic>=0.64.0",
"chromadb==1.0.21",
"onnxruntime<1.24.1;python_version<'3.11'",
- "onnxruntime>=1.24.1;python_version>='3.11'",
Review Comment:
>It actually won't cause any failure, but may be unexpected.
@wenjin272 You are right on `onnxruntime==1.23.2` is automatically resolved
and picked up by uv. I think this is because of uv's universal resolver no
longer needs to fork based on current constraints:
- Python <3.11: onnxruntime<1.24.1 (from pyproject.toml)
- Python >=3.11: onnxruntime with no version pin (from chromadb)
Since 1.23.2 satisfies both, uv unifies on a single version rather than
forking. I would say this is **expected** from uv perspective, and the version
`1.23.2` should work well with all Python versions we supported today.
**Note**: that the root cause here is upstream: chromadb declares
https://github.com/chroma-core/chroma/blob/main/pyproject.toml#L10 with no
upper bound and no platform markers. This means chromadb is unaware that newer
onnxruntime releases may drop support for certain platforms (like macOS x86_64
in 1.24.1). Ideally, chromadb should handle this with appropriate version
bounds or environment markers so that downstream projects don't need to
independently work around these compatibility gaps.
-------
I don't see a hard blocker that we had to to remove the support on `macOS
x86_64`. That said, I think we should continue to support `macOS x86_64`. There
are still users(like us internally) replies on the builds from `macOS x86_64`.
@wenjin272 @xintongsong WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
